speed up item synchronization and add trader items limit

add mutator group name

.editorconfig

@@ -0,0 +1,33 @@
+root = true
+
+# Global
+[*]
+indent_style = unset
+indent_size = 4
+tab_width = 4
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = unset
+
+# Unreal Engine 3 / Source
+[*.uc]
+indent_style = tab
+
+[*.{uci,upkg}]
+
+# Unreal Engine 3 / i18n
+[*.{chn,cht,cze,dan,deu,dut,esl,esn,fra,frc,hun,int,ita,jpn,kor,pol,por,ptb,rus,tur,ukr}]
+charset = utf-16le
+
+# Other
+[*.md]
+indent_style = space
+trim_trailing_whitespace = false
+
+[*.yml]
+indent_style = space
+indent_size = 2
+
+[*.{txt,cfg,conf}]
+indent_style = tab

.github/workflows/mega-linter.yml

@@ -0,0 +1,72 @@
+---
+name: MegaLinter
+
+permissions: read-all
+
+on:
+  push:
+  pull_request:
+    branches: [master]
+
+env:
+  APPLY_FIXES: none
+  APPLY_FIXES_EVENT: pull_request
+  APPLY_FIXES_MODE: commit
+  DISABLE: SPELL
+
+concurrency:
+  group: ${{ github.ref }}-${{ github.workflow }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    name: MegaLinter
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.PAT || secrets.GITHUB_TOKEN }}
+
+      - name: MegaLinter
+        id: ml
+        uses: oxsecurity/megalinter@v6
+        env:
+          VALIDATE_ALL_CODEBASE: true
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Archive production artifacts
+        if: ${{ success() }} || ${{ failure() }}
+        uses: actions/upload-artifact@v3
+        with:
+          name: MegaLinter reports
+          path: |
+            megalinter-reports
+            mega-linter.log
+
+      - name: Create Pull Request with applied fixes
+        id: cpr
+        if: steps.ml.outputs.has_updated_sources == 1 && (env.APPLY_FIXES_EVENT == 'all' || env.APPLY_FIXES_EVENT == github.event_name) && env.APPLY_FIXES_MODE == 'pull_request' && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository)
+        uses: peter-evans/create-pull-request@v5
+        with:
+          token: ${{ secrets.PAT || secrets.GITHUB_TOKEN }}
+          commit-message: "[MegaLinter] Apply linters automatic fixes"
+          title: "[MegaLinter] Apply linters automatic fixes"
+          labels: bot
+      - name: Create PR output
+        if: steps.ml.outputs.has_updated_sources == 1 && (env.APPLY_FIXES_EVENT == 'all' || env.APPLY_FIXES_EVENT == github.event_name) && env.APPLY_FIXES_MODE == 'pull_request' && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository)
+        run: |
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
+          echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"
+
+      - name: Prepare commit
+        if: steps.ml.outputs.has_updated_sources == 1 && (env.APPLY_FIXES_EVENT == 'all' || env.APPLY_FIXES_EVENT == github.event_name) && env.APPLY_FIXES_MODE == 'commit' && github.ref != 'refs/heads/main' && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository)
+        run: sudo chown -Rc $UID .git/
+      - name: Commit and push applied linter fixes
+        if: steps.ml.outputs.has_updated_sources == 1 && (env.APPLY_FIXES_EVENT == 'all' || env.APPLY_FIXES_EVENT == github.event_name) && env.APPLY_FIXES_MODE == 'commit' && github.ref != 'refs/heads/main' && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository)
+        uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          branch: ${{ github.event.pull_request.head.ref || github.head_ref || github.ref }}
+          commit_message: "[MegaLinter] Apply linters fixes"
+          commit_user_name: megalinter-bot
+          commit_user_email: nicolas.vuillamy@ox.security

CTI/Classes/CTI.uc

@@ -1,7 +1,7 @@
 class CTI extends Info
 	config(CTI);
 
-const LatestVersion = 3;
+const LatestVersion = 4;
 
 const CfgRemoveItems     = class'RemoveItems';
 const CfgAddItems        = class'AddItems';
@@ -22,10 +22,12 @@ var private config E_LogLevel LogLevel;
 var private config String     UnlockDLC;
 var private config bool       bPreloadContent;
 var private config bool       bOfficialWeaponsList;
+var private config bool       bDisableItemLimitCheck;
 
-var private KFGameInfo KFGI;
+var private KFGameInfo            KFGI;
 var private KFGameReplicationInfo KFGRI;
 
+var private Array<class<KFWeaponDefinition> > WeapDefs;
 var private Array<class<KFWeaponDefinition> > RemoveItems;
 var private Array<class<KFWeaponDefinition> > AddItems;
 
@@ -33,8 +35,6 @@ var private Array<CTI_RepInfo> RepInfos;
 
 var private bool ReadyToSync;
 
-var private Array<S_PreloadContent> PreloadContent;
-
 public simulated function bool SafeDestroy()
 {
 	`Log_Trace();
@@ -95,6 +95,8 @@ private function PreInit()
 			bOfficialWeaponsList = false;
 
 		case 2:
+		case 3:
+			bDisableItemLimitCheck = false;
 
 		case MaxInt:
 			`Log_Info("Config updated to version" @ LatestVersion);
@@ -129,7 +131,7 @@ private function PreInit()
 
 	if (!Unlocker.static.IsValidTypeUnlockDLC(UnlockDLC, LogLevel))
 	{
-		`Log_Warn("Wrong 'UnlockDLC' (" $ UnlockDLC $ "), return to default value (False)");
+		`Log_Warn("Wrong 'UnlockDLC' value (" $ UnlockDLC $ "), return to default value (False)");
 		UnlockDLC = "False";
 		SaveConfig();
 	}
@@ -189,34 +191,35 @@ private function PostInit()
 		CfgRemoveItems.default.bAll,
 		CfgRemoveItems.default.bHRG,
 		CfgRemoveItems.default.bDLC,
+		bDisableItemLimitCheck,
 		LogLevel);
 
+	WeapDefs = Trader.static.GetTraderWeapDefs(KFGRI, LogLevel);
+
 	ReadyToSync = true;
 
 	foreach RepInfos(RepInfo)
 	{
 		if (RepInfo.PendingSync)
 		{
-			RepInfo.ServerSync();
+			RepInfo.Replicate(WeapDefs);
 		}
 	}
 }
 
-private function Preload(Array<class<KFWeaponDefinition> > Content)
+private function Preload(const out Array<class<KFWeaponDefinition> > Content)
 {
-	local Array<class<KFWeapon> > OfficialWeapons;
+	local Array<S_PreloadContent> PreloadContent;
 	local S_PreloadContent SPC;
 
 	`Log_Trace();
 
-	OfficialWeapons = Trader.static.GetTraderWeapons();
-	
 	foreach Content(SPC.KFWD)
 	{
 		SPC.KFWC = class<KFWeapon> (DynamicLoadObject(SPC.KFWD.default.WeaponClassPath, class'Class'));
 		if (SPC.KFWC != None)
 		{
-			if (OfficialWeapons.Find(SPC.KFWC) != INDEX_NONE)
+			if (SPC.KFWC.GetPackageName() == 'CTI' || SPC.KFWC.GetPackageName() == 'KFGameContent')
 			{
 				`Log_Debug("Skip preload:" @ SPC.KFWD.GetPackageName() $ "." $ SPC.KFWD);
 				continue;
@@ -271,26 +274,19 @@ public function bool CreateRepInfo(Controller C)
 
 	`Log_Trace();
 
-	if (C == None) return false;
+	if (C == None || KFPlayerController(C) == None) return false;
 
 	RepInfo = Spawn(class'CTI_RepInfo', C);
 
 	if (RepInfo == None) return false;
 
-	RepInfo.PrepareSync(
-		Self,
-		LogLevel,
-		RemoveItems,
-		AddItems,
-		CfgRemoveItems.default.bAll,
-		CfgRemoveItems.default.bHRG,
-		CfgRemoveItems.default.bDLC);
+	RepInfo.PrepareSync(Self, KFPlayerController(C), LogLevel);
 
 	RepInfos.AddItem(RepInfo);
 
 	if (ReadyToSync)
 	{
-		RepInfo.ServerSync();
+		RepInfo.Replicate(WeapDefs);
 	}
 	else
 	{

CTI/Classes/CTIMut.uc

@@ -35,7 +35,7 @@ public function AddMutator(Mutator Mut)
 	if (Mut == Self) return;
 
 	if (Mut.Class == Class)
-		Mut.Destroy();
+		CTIMut(Mut).SafeDestroy();
 	else
 		Super.AddMutator(Mut);
 }
@@ -56,5 +56,5 @@ public function NotifyLogout(Controller C)
 
 DefaultProperties
 {
-
+	GroupNames.Add("TraderItems")
 }

CTI/Classes/CTI_GFxTraderContainer_Store.uc

@@ -11,7 +11,7 @@ function bool IsItemFiltered(STraderItem Item, optional bool bDebug)
 	if (Item.WeaponDef.default.PlatformRestriction != PR_All && class'KFUnlockManager'.static.IsPlatformRestricted(Item.WeaponDef.default.PlatformRestriction))
 		return true;
 
-   	return false;
+	return false;
 }
 
 defaultproperties

CTI/Classes/CTI_LocalMessage.uc

@@ -4,29 +4,29 @@ class CTI_LocalMessage extends Object
 var const             String SyncItemsDefault;
 var private localized String SyncItems;
 
-var const             String SyncFinishedDefault;
-var private localized String SyncFinished;
-
 var const             String WaitingGRIDefault;
 var private localized String WaitingGRI;
 
 var const             String IncompatibleGRIDefault;
 var private localized String IncompatibleGRI;
 
-var const             String DisconnectDefault;
-var private localized String Disconnect;
+var const             String IncompatibleGRIWarningDefault;
+var private localized String IncompatibleGRIWarning;
 
 var const             String SecondsShortDefault;
 var private localized String SecondsShort;
 
+var const             String PleaseWaitDefault;
+var private localized String PleaseWait;
+
 enum E_CTI_LocalMessageType
 {
 	CTI_SyncItems,
-	CTI_SyncFinished,
 	CTI_WaitingGRI,
 	CTI_IncompatibleGRI,
-	CTI_Disconnect,
-	CTI_SecondsShort
+	CTI_IncompatibleGRIWarning,
+	CTI_SecondsShort,
+	CTI_PleaseWait
 };
 
 public static function String GetLocalizedString(
@@ -43,20 +43,20 @@ public static function String GetLocalizedString(
 		case CTI_SyncItems:
 			return (default.SyncItems != "" ? default.SyncItems : default.SyncItemsDefault);
 
-		case CTI_SyncFinished:
-			return (default.SyncFinished != "" ? default.SyncFinished : default.SyncFinishedDefault);
-		
 		case CTI_WaitingGRI:
 			return (default.WaitingGRI != "" ? default.WaitingGRI : default.WaitingGRIDefault);
 
 		case CTI_IncompatibleGRI:
-			return (default.IncompatibleGRI != "" ? default.IncompatibleGRI : default.IncompatibleGRIDefault);
+			return (default.IncompatibleGRI != "" ? default.IncompatibleGRI : default.IncompatibleGRIDefault) @ String1;
 
-		case CTI_Disconnect:
-			return (default.Disconnect != "" ? default.Disconnect : default.DisconnectDefault);
+		case CTI_IncompatibleGRIWarning:
+			return (default.IncompatibleGRIWarning != "" ? default.IncompatibleGRIWarning : default.IncompatibleGRIWarningDefault);
 
 		case CTI_SecondsShort:
 			return (default.SecondsShort != "" ? default.SecondsShort : default.SecondsShortDefault);
+
+		case CTI_PleaseWait:
+			return (default.PleaseWait != "" ? default.PleaseWait : default.PleaseWaitDefault);
 	}
 
 	return "";
@@ -64,10 +64,10 @@ public static function String GetLocalizedString(
 
 defaultproperties
 {
-	SyncItemsDefault       = "Sync items:"
-	SyncFinishedDefault    = "Sync finished."
-	WaitingGRIDefault      = "Waiting GRI..."
-	IncompatibleGRIDefault = "Incompatible GRI:"
-	DisconnectDefault      = "Disconnect..."
-	SecondsShortDefault    = "s"
+	SyncItemsDefault              = "Sync items:"
+	WaitingGRIDefault             = "Waiting GRI..."
+	IncompatibleGRIDefault        = "Incompatible GRI:"
+	IncompatibleGRIWarningDefault = "You can enter the game, but the trader may not work correctly.";
+	SecondsShortDefault           = "s"
+	PleaseWaitDefault             = "Please wait"
 }

CTI/Classes/CTI_RepInfo.uc

@@ -1,21 +1,23 @@
 class CTI_RepInfo extends ReplicationInfo;
 
+const CAPACITY = 64; // max: 128
+
 const Trader       = class'Trader';
 const LocalMessage = class'CTI_LocalMessage';
 
+struct ReplicationStruct
+{
+	var int Size;
+	var int Transfered;
+
+	var class<KFWeaponDefinition> Items[CAPACITY];
+	var int Length;
+};
+
 var public  bool PendingSync;
 
 var private CTI CTI;
 var private E_LogLevel LogLevel;
-var private Array<class<KFWeaponDefinition> > RemoveItems;
-var private Array<class<KFWeaponDefinition> > AddItems;
-var private bool ReplaceMode;
-var private bool RemoveHRG;
-var private bool RemoveDLC;
-var private bool PreloadContent;
-
-var private int  Recieved;
-var private int  SyncSize;
 
 var private KFPlayerController      KFPC;
 var private KFGFxWidget_PartyInGame PartyInGameWidget;
@@ -27,11 +29,15 @@ var private String NotificationRightText;
 var private int    NotificationPercent;
 
 var private int    WaitingGRI;
+var private int    WaitingGRILimit;
+
+var private ReplicationStruct                 RepData;
+var private Array<class<KFWeaponDefinition> > RepArray;
 
 replication
 {
 	if (bNetInitial && Role == ROLE_Authority)
-		LogLevel, ReplaceMode, RemoveHRG, RemoveDLC, SyncSize;
+		LogLevel;
 }
 
 public simulated function bool SafeDestroy()
@@ -41,25 +47,116 @@ public simulated function bool SafeDestroy()
 	return (bPendingDelete || bDeleteMe || Destroy());
 }
 
-public function PrepareSync(
-	CTI _CTI,
-	E_LogLevel _LogLevel,
-	Array<class<KFWeaponDefinition> > _RemoveItems,
-	Array<class<KFWeaponDefinition> > _AddItems,
-	bool _ReplaceMode,
-	bool _RemoveHRG,
-	bool _RemoveDLC)
+public function Replicate(const out Array<class<KFWeaponDefinition> > WeapDefs)
 {
 	`Log_Trace();
 
-	CTI                 = _CTI;
-	LogLevel            = _LogLevel;
-	RemoveItems         = _RemoveItems;
-	AddItems            = _AddItems;
-	ReplaceMode         = _ReplaceMode;
-	RemoveHRG           = _RemoveHRG;
-	RemoveDLC           = _RemoveDLC;
-	SyncSize            = RemoveItems.Length + AddItems.Length;
+	RepArray = WeapDefs;
+	RepData.Size = RepArray.Length;
+
+	if (WorldInfo.NetMode == NM_StandAlone)
+	{
+		Progress(RepArray.Length, RepArray.Length);
+		return;
+	}
+
+	Sync();
+}
+
+private reliable server function Sync()
+{
+	local int  LocalIndex;
+	local int  GlobalIndex;
+
+	`Log_Trace();
+
+	LocalIndex = 0;
+	GlobalIndex = RepData.Transfered;
+
+	while (LocalIndex < CAPACITY && GlobalIndex < RepData.Size)
+	{
+		RepData.Items[LocalIndex++] = RepArray[GlobalIndex++];
+	}
+
+	if (RepData.Transfered == GlobalIndex) return; // Finished
+
+	RepData.Transfered = GlobalIndex;
+	RepData.Length = LocalIndex;
+
+	Send(RepData);
+
+	Progress(RepData.Transfered, RepData.Size);
+}
+
+private reliable client function Send(ReplicationStruct RD)
+{
+	local int LocalIndex;
+
+	`Log_Trace();
+
+	for (LocalIndex = 0; LocalIndex < RD.Length; LocalIndex++)
+	{
+		RepArray.AddItem(RD.Items[LocalIndex]);
+	}
+
+	Progress(RD.Transfered, RD.Size);
+
+	Sync();
+}
+
+public function PrepareSync(CTI _CTI, KFPlayerController _KFPC, E_LogLevel _LogLevel)
+{
+	`Log_Trace();
+
+	CTI      = _CTI;
+	KFPC     = _KFPC;
+	LogLevel = _LogLevel;
+}
+
+private simulated function Progress(int Value, int Size)
+{
+	`Log_Trace();
+
+	`Log_Debug("Replicated:" @ Value @ "/" @ Size);
+
+	if (ROLE < ROLE_Authority)
+	{
+		NotifyProgress(Value, Size);
+		if (Value >= Size) Finished();
+	}
+}
+
+private simulated function Finished()
+{
+	local KFGameReplicationInfo KFGRI;
+
+	`Log_Trace();
+
+	if (WorldInfo.GRI == None && WaitingGRI++ < WaitingGRILimit)
+	{
+		`Log_Debug("Finished: Waiting GRI" @ WaitingGRI);
+		NotifyWaitingGRI();
+		SetTimer(1.0f, false, nameof(Finished));
+		return;
+	}
+
+	KFGRI = KFGameReplicationInfo(WorldInfo.GRI);
+	if (KFGRI != None)
+	{
+		`Log_Debug("Finished: Trader.static.OverwriteTraderItems");
+		Trader.static.OverwriteTraderItems(KFGRI, RepArray, LogLevel);
+		`Log_Info("Trader items successfully synchronized!");
+	}
+	else
+	{
+		`Log_Error("Incompatible Replication info:" @ String(WorldInfo.GRI));
+		NotifyIncompatibleGRI();
+	}
+
+	ShowReadyButton();
+
+	Cleanup();
+	SafeDestroy();
 }
 
 private simulated function KFPlayerController GetKFPC()
@@ -78,6 +175,39 @@ private simulated function KFPlayerController GetKFPC()
 	return KFPC;
 }
 
+public reliable client function WriteToChatLocalized(
+	E_CTI_LocalMessageType LMT,
+	optional String HexColor,
+	optional String String1,
+	optional String String2,
+	optional String String3)
+{
+	`Log_Trace();
+
+	WriteToChat(LocalMessage.static.GetLocalizedString(LogLevel, LMT, String1, String2, String3), HexColor);
+}
+
+public reliable client function WriteToChat(String Message, optional String HexColor)
+{
+	local KFGFxHudWrapper HUD;
+
+	`Log_Trace();
+
+	if (GetKFPC() == None) return;
+
+	if (KFPC.MyGFxManager.PartyWidget != None && KFPC.MyGFxManager.PartyWidget.PartyChatWidget != None)
+	{
+		KFPC.MyGFxManager.PartyWidget.PartyChatWidget.SetVisible(true);
+		KFPC.MyGFxManager.PartyWidget.PartyChatWidget.AddChatMessage(Message, HexColor);
+	}
+
+	HUD = KFGFxHudWrapper(KFPC.myHUD);
+	if (HUD != None && HUD.HUDMovie != None && HUD.HUDMovie.HudChatBox != None)
+	{
+		HUD.HUDMovie.HudChatBox.AddChatMessage(Message, HexColor);
+	}
+}
+
 private simulated function SetPartyInGameWidget()
 {
 	`Log_Trace();
@@ -117,6 +247,8 @@ private simulated function ShowReadyButton()
 {
 	`Log_Trace();
 
+	ClearTimer(nameof(KeepNotification));
+
 	if (CheckPartyInGameWidget())
 	{
 		Notification.SetVisible(false);
@@ -142,48 +274,6 @@ private simulated function UpdateNotification(String Title, String Left, String
 	}
 }
 
-private reliable client function ClientSync(class<KFWeaponDefinition> WeapDef, optional bool Remove = false)
-{
-	`Log_Trace();
-
-	if (WeapDef == None)
-	{
-		`Log_Fatal("WeapDef is:" @ WeapDef);
-		Cleanup();
-		ConsoleCommand("Disconnect");
-		SafeDestroy();
-		return;
-	}
-	
-	if (!IsTimerActive(nameof(KeepNotification)))
-	{
-		SetTimer(0.1f, true, nameof(KeepNotification));
-	}
-	
-	if (Remove)
-	{
-		RemoveItems.AddItem(WeapDef);
-	}
-	else
-	{
-		AddItems.AddItem(WeapDef);
-	}
-	
-	Recieved = RemoveItems.Length + AddItems.Length;
-	
-	NotificationHeaderText  = (Remove ? "-" : "+") @ WeapDef.static.GetItemName();
-	NotificationLeftText    = LocalMessage.static.GetLocalizedString(LogLevel, CTI_SyncItems);
-	NotificationRightText   = Recieved @ "/" @ SyncSize;
-	if (SyncSize != 0)
-	{
-		NotificationPercent = (float(Recieved) / float(SyncSize)) * 100;
-	}
-	
-	`Log_Debug("ClientSync:" @ (Remove ? "-" : "+") @ String(WeapDef) @ NotificationRightText);
-	
-	ServerSync();
-}
-
 private simulated function KeepNotification()
 {
 	HideReadyButton();
@@ -194,94 +284,55 @@ private simulated function KeepNotification()
 		NotificationPercent);
 }
 
-private simulated reliable client function ClientSyncFinished()
-{
-	local KFGameReplicationInfo KFGRI;
-
-	`Log_Trace();
-	
-	NotificationLeftText  = "";
-	NotificationRightText = "";
-	NotificationPercent   = 0;
-	
-	if (WorldInfo.GRI == None)
-	{
-		`Log_Debug("ClientSyncFinished: Waiting GRI");
-		NotificationHeaderText = LocalMessage.static.GetLocalizedString(LogLevel, CTI_WaitingGRI);
-		NotificationLeftText   = String(++WaitingGRI) $ LocalMessage.static.GetLocalizedString(LogLevel, CTI_SecondsShort);
-		NotificationRightText  = "";
-		SetTimer(1.0f, false, nameof(ClientSyncFinished));
-		return;
-	}
-	
-	KFGRI = KFGameReplicationInfo(WorldInfo.GRI);
-	if (KFGRI == None)
-	{
-		`Log_Fatal("Incompatible Replication info:" @ String(WorldInfo.GRI));
-		ClearTimer(nameof(KeepNotification));
-		UpdateNotification(
-			LocalMessage.static.GetLocalizedString(LogLevel, CTI_IncompatibleGRI) @ String(WorldInfo.GRI),
-			LocalMessage.static.GetLocalizedString(LogLevel, CTI_Disconnect), "", 0);
-		Cleanup();
-		ConsoleCommand("Disconnect");
-		SafeDestroy();
-		return;
-	}
-	
-	NotificationHeaderText = LocalMessage.static.GetLocalizedString(LogLevel, CTI_SyncFinished);
-	NotificationLeftText   = "";
-	NotificationRightText  = "";
-	NotificationPercent    = 0;
-
-	Trader.static.ModifyTrader(KFGRI, RemoveItems, AddItems, ReplaceMode, RemoveHRG, RemoveDLC, LogLevel);
-	`Log_Debug("ClientSyncFinished: Trader.static.ModifyTrader");
-
-	ClearTimer(nameof(KeepNotification)); 
-	ShowReadyButton();
-	
-	Cleanup();
-	
-	SafeDestroy();
-}
-
 private reliable server function Cleanup()
 {
 	`Log_Trace();
 
 	`Log_Debug("Cleanup");
-	if (!CTI.DestroyRepInfo(Controller(Owner)))
+	if (!CTI.DestroyRepInfo(GetKFPC()))
 	{
 		`Log_Debug("Cleanup (forced)");
 		SafeDestroy();
 	}
 }
 
-public reliable server function ServerSync()
+private simulated function NotifyWaitingGRI()
 {
-	`Log_Trace();
-	
-	PendingSync = false;
-	
-	if (bPendingDelete || bDeleteMe) return;
-	
-	if (SyncSize <= Recieved || WorldInfo.NetMode == NM_StandAlone)
+	if (!IsTimerActive(nameof(KeepNotification)))
 	{
-		`Log_Debug("ServerSync: Finished");
-		ClientSyncFinished();
+		SetTimer(0.1f, true, nameof(KeepNotification));
 	}
-	else
+
+	NotificationHeaderText = LocalMessage.static.GetLocalizedString(LogLevel, CTI_WaitingGRI);
+	NotificationLeftText   = String(WaitingGRI) $ LocalMessage.static.GetLocalizedString(LogLevel, CTI_SecondsShort);
+	NotificationRightText  = LocalMessage.static.GetLocalizedString(LogLevel, CTI_PleaseWait);
+	NotificationPercent    = 0;
+	KeepNotification();
+}
+
+private simulated function NotifyProgress(int Value, int Size)
+{
+	if (!IsTimerActive(nameof(KeepNotification)))
 	{
-		if (Recieved < RemoveItems.Length)
-		{
-			`Log_Debug("ServerSync[-]:" @ (Recieved + 1) @ "/" @ SyncSize @ RemoveItems[Recieved]);
-			ClientSync(RemoveItems[Recieved++], true);
-		}
-		else
-		{
-			`Log_Debug("ServerSync[+]:" @ (Recieved + 1) @ "/" @ SyncSize @ AddItems[Recieved - RemoveItems.Length]);
-			ClientSync(AddItems[Recieved++ - RemoveItems.Length], false);
-		}
+		SetTimer(0.1f, true, nameof(KeepNotification));
 	}
+
+	NotificationHeaderText  = LocalMessage.static.GetLocalizedString(LogLevel, CTI_SyncItems);
+	NotificationLeftText    = Value @ "/" @ Size;
+	NotificationRightText   = LocalMessage.static.GetLocalizedString(LogLevel, CTI_PleaseWait);
+	NotificationPercent     = (float(Value) / float(Size)) * 100;
+	KeepNotification();
+}
+
+private simulated function NotifyIncompatibleGRI()
+{
+	WriteToChatLocalized(
+		CTI_IncompatibleGRI,
+		class'KFLocalMessage'.default.InteractionColor,
+		String(WorldInfo.GRI.class));
+	WriteToChatLocalized(
+		CTI_IncompatibleGRIWarning,
+		class'KFLocalMessage'.default.InteractionColor);
 }
 
 defaultproperties
@@ -291,8 +342,8 @@ defaultproperties
 	bSkipActorPropertyReplication = false
 
 	PendingSync = false
-	Recieved    = 0
 
 	NotificationPercent    = 0
 	WaitingGRI             = 0
+	WaitingGRILimit        = 30
 }

CTI/Classes/CTI_WeapDef_AutoTurret.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_AutoTurret extends KFWeapDef_AutoTurret
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_AutoTurret'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_AutoTurret"
 }

CTI/Classes/CTI_WeapDef_BladedPistol.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_BladedPistol extends KFWeapDef_BladedPistol
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_BladedPistol'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_Bladed"
 }

CTI/Classes/CTI_WeapDef_Blunderbuss.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Blunderbuss extends KFWeapDef_Blunderbuss
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Blunderbuss'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_Blunderbuss"
 }

CTI/Classes/CTI_WeapDef_ChainBat.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ChainBat extends KFWeapDef_ChainBat
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ChainBat'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Blunt_ChainBat"
 }

CTI/Classes/CTI_WeapDef_ChiappaRhino.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ChiappaRhino extends KFWeapDef_ChiappaRhino
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ChiappaRhino'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_ChiappaRhino"
 }

CTI/Classes/CTI_WeapDef_ChiappaRhinoDual.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ChiappaRhinoDual extends KFWeapDef_ChiappaRhinoDual
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ChiappaRhinoDual'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_ChiappaRhinoDual"
 }

CTI/Classes/CTI_WeapDef_CompoundBow.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_CompoundBow extends KFWeapDef_CompoundBow
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_CompoundBow'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Bow_CompoundBow"
 }

CTI/Classes/CTI_WeapDef_Doshinegun.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Doshinegun extends KFWeapDef_Doshinegun
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Doshinegun'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_AssaultRifle_Doshinegun"
 }

CTI/Classes/CTI_WeapDef_DualBladed.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_DualBladed extends KFWeapDef_DualBladed
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_DualBladed'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_DualBladed"
 }

CTI/Classes/CTI_WeapDef_FAMAS.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_FAMAS extends KFWeapDef_FAMAS
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_FAMAS'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_AssaultRifle_FAMAS"
 }

CTI/Classes/CTI_WeapDef_G18.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_G18 extends KFWeapDef_G18
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_G18'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_SMG_G18"
 }

CTI/Classes/CTI_WeapDef_G36C.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_G36C extends KFWeapDef_G36C
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_G36C'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_AssaultRifle_G36C"
 }

CTI/Classes/CTI_WeapDef_GravityImploder.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_GravityImploder extends KFWeapDef_GravityImploder
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_GravityImploder'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_GravityImploder"
 }

CTI/Classes/CTI_WeapDef_HVStormCannon.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_HVStormCannon extends KFWeapDef_HVStormCannon
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_HVStormCannon'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_HVStormCannon"
 }

CTI/Classes/CTI_WeapDef_IonThruster.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_IonThruster extends KFWeapDef_IonThruster
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_IonThruster'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Edged_IonThruster"
 }

CTI/Classes/CTI_WeapDef_Mine_Reconstructor.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Mine_Reconstructor extends KFWeapDef_Mine_Reconstructor
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Mine_Reconstructor'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Mine_Reconstructor"
 }

CTI/Classes/CTI_WeapDef_Minigun.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Minigun extends KFWeapDef_Minigun
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Minigun'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Minigun"
 }

CTI/Classes/CTI_WeapDef_MosinNagant.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_MosinNagant extends KFWeapDef_MosinNagant
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_MosinNagant'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Rifle_MosinNagant"
 }

CTI/Classes/CTI_WeapDef_ParasiteImplanter.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ParasiteImplanter extends KFWeapDef_ParasiteImplanter
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ParasiteImplanter'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Rifle_ParasiteImplanter"
 }

CTI/Classes/CTI_WeapDef_Pistol_DualG18.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Pistol_DualG18 extends KFWeapDef_Pistol_DualG18
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Pistol_DualG18'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_DualG18"
 }

CTI/Classes/CTI_WeapDef_Pistol_G18C.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Pistol_G18C extends KFWeapDef_Pistol_G18C
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Pistol_G18C'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Pistol_G18C"
 }

CTI/Classes/CTI_WeapDef_Rifle_FrostShotgunAxe.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Rifle_FrostShotgunAxe extends KFWeapDef_Rifle_FrostShotgunAxe
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Rifle_FrostShotgunAxe'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Rifle_FrostShotgunAxe"
 }

CTI/Classes/CTI_WeapDef_Scythe.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Scythe extends KFWeapDef_Scythe
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Scythe'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Edged_Scythe"
 }

CTI/Classes/CTI_WeapDef_Shotgun_S12.uc

@@ -0,0 +1,15 @@
+class CTI_WeapDef_Shotgun_S12 extends KFWeapDef_Shotgun_S12
+	abstract;
+
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Shotgun_S12'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
+defaultproperties
+{
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Shotgun_S12"
+}

CTI/Classes/CTI_WeapDef_ShrinkRayGun.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ShrinkRayGun extends KFWeapDef_ShrinkRayGun
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ShrinkRayGun'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_ShrinkRayGun"
 }

CTI/Classes/CTI_WeapDef_ThermiteBore.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ThermiteBore extends KFWeapDef_ThermiteBore
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ThermiteBore'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_RocketLauncher_ThermiteBore"
 }

CTI/Classes/CTI_WeapDef_ZedMKIII.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_ZedMKIII extends KFWeapDef_ZedMKIII
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_ZedMKIII'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_ZedMKIII"
 }

CTI/Classes/CTI_WeapDef_Zweihander.uc

@@ -1,7 +1,15 @@
 class CTI_WeapDef_Zweihander extends KFWeapDef_Zweihander
 	abstract;
 
+static function String GetItemLocalization(String KeyName)
+{
+	local Array<String> Strings;
+	ParseStringIntoArray(class'KFGame.KFWeapDef_Zweihander'.default.WeaponClassPath, Strings, ".", true);
+	return Localize(Strings[1], KeyName, Strings[0]);
+}
+
 defaultproperties
 {
-	SharedUnlockId = SCU_None
+	SharedUnlockId  = SCU_None
+	WeaponClassPath = "CTI.CTI_Weap_Edged_Zweihander"
 }

CTI/Classes/CTI_Weap_AssaultRifle_Doshinegun.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_AssaultRifle_Doshinegun extends KFWeap_AssaultRifle_Doshinegun;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_AssaultRifle_FAMAS.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_AssaultRifle_FAMAS extends KFWeap_AssaultRifle_FAMAS;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_AssaultRifle_G36C.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_AssaultRifle_G36C extends KFWeap_AssaultRifle_G36C;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_AutoTurret.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_AutoTurret extends KFWeap_AutoTurret;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Blunt_ChainBat.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Blunt_ChainBat extends KFWeap_Blunt_ChainBat;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Bow_CompoundBow.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Bow_CompoundBow extends KFWeap_Bow_CompoundBow;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Edged_IonThruster.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Edged_IonThruster extends KFWeap_Edged_IonThruster;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Edged_Scythe.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Edged_Scythe extends KFWeap_Edged_Scythe;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Edged_Zweihander.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Edged_Zweihander extends KFWeap_Edged_Zweihander;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_GravityImploder.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_GravityImploder extends KFWeap_GravityImploder;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_HVStormCannon.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_HVStormCannon extends KFWeap_HVStormCannon;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Mine_Reconstructor.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Mine_Reconstructor extends KFWeap_Mine_Reconstructor;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Minigun.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Minigun extends KFWeap_Minigun;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_Bladed.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_Bladed extends KFWeap_Pistol_Bladed;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_Blunderbuss.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_Blunderbuss extends KFWeap_Pistol_Blunderbuss;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_ChiappaRhino.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_ChiappaRhino extends KFWeap_Pistol_ChiappaRhino;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_ChiappaRhinoDual.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_ChiappaRhinoDual extends KFWeap_Pistol_ChiappaRhinoDual;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_DualBladed.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_DualBladed extends KFWeap_Pistol_DualBladed;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_DualG18.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_DualG18 extends KFWeap_Pistol_DualG18;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Pistol_G18C.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Pistol_G18C extends KFWeap_Pistol_G18C;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Rifle_FrostShotgunAxe.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Rifle_FrostShotgunAxe extends KFWeap_Rifle_FrostShotgunAxe;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Rifle_MosinNagant.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Rifle_MosinNagant extends KFWeap_Rifle_MosinNagant;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Rifle_ParasiteImplanter.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Rifle_ParasiteImplanter extends KFWeap_Rifle_ParasiteImplanter;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_RocketLauncher_ThermiteBore.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_RocketLauncher_ThermiteBore extends KFWeap_RocketLauncher_ThermiteBore;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_SMG_G18.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_SMG_G18 extends KFWeap_SMG_G18;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_Shotgun_S12.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_Shotgun_S12 extends KFWeap_Shotgun_S12;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_ShrinkRayGun.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_ShrinkRayGun extends KFWeap_ShrinkRayGun;
+
+defaultproperties
+{
+
+}

CTI/Classes/CTI_Weap_ZedMKIII.uc

@@ -0,0 +1,6 @@
+class CTI_Weap_ZedMKIII extends KFWeap_ZedMKIII;
+
+defaultproperties
+{
+
+}

CTI/Classes/Trader.uc

@@ -1,6 +1,11 @@
 class Trader extends Object
 	abstract;
 
+// Bug:
+// The wrong weapon is purchased if the index is greater than 256 😡
+// Some greedy guy saved 3 bytes for no reason again
+const ITEMS_LIMIT = 256;
+
 private delegate int ByPrice(class<KFWeaponDefinition> A, class<KFWeaponDefinition> B)
 {
 	return A.default.BuyPrice > B.default.BuyPrice ? -1 : 0;
@@ -22,7 +27,7 @@ public static function KFGFxObject_TraderItems GetTraderItems(optional KFGameRep
 	return KFGFxObject_TraderItems(DynamicLoadObject(TraderItemsPath, class'KFGFxObject_TraderItems'));
 }
 
-public static function Array<class<KFWeaponDefinition> > GetTraderWeapDefs(optional KFGameReplicationInfo KFGRI = None,optional E_LogLevel LogLevel = LL_Trace)
+public static function Array<class<KFWeaponDefinition> > GetTraderWeapDefs(optional KFGameReplicationInfo KFGRI = None, optional E_LogLevel LogLevel = LL_Trace)
 {
 	local Array<class<KFWeaponDefinition> > KFWeapDefs;
 	local KFGFxObject_TraderItems TraderItems;
@@ -41,7 +46,7 @@ public static function Array<class<KFWeaponDefinition> > GetTraderWeapDefs(optio
 	return KFWeapDefs;
 }
 
-public static function Array<class<KFWeapon> > GetTraderWeapons(optional KFGameReplicationInfo KFGRI = None,optional E_LogLevel LogLevel = LL_Trace)
+public static function Array<class<KFWeapon> > GetTraderWeapons(optional KFGameReplicationInfo KFGRI = None, optional E_LogLevel LogLevel = LL_Trace)
 {
 	local Array<class<KFWeapon> > KFWeapons;
 	local class<KFWeapon> KFWeapon;
@@ -88,19 +93,18 @@ public static function Array<class<KFWeaponDefinition> > GetTraderWeapDefsDLC(KF
 
 public static simulated function ModifyTrader(
 	KFGameReplicationInfo KFGRI,
-	Array<class<KFWeaponDefinition> > RemoveItems,
-	Array<class<KFWeaponDefinition> > AddItems,
+	const out Array<class<KFWeaponDefinition> > RemoveItems,
+	const out Array<class<KFWeaponDefinition> > AddItems,
 	bool ReplaceMode,
 	bool RemoveHRG,
 	bool RemoveDLC,
+	bool bDisableItemLimitCheck,
 	E_LogLevel LogLevel)
 {
 	local KFGFxObject_TraderItems TraderItems;
 	local STraderItem Item;
-	local class<KFWeaponDefinition> WeapDef;
 	local Array<class<KFWeaponDefinition> > WeapDefs;
 	local int Index;
-	local int MaxItemID;
 
 	`Log_TraceStatic();
 
@@ -128,13 +132,44 @@ public static simulated function ModifyTrader(
 
 	WeapDefs.Sort(ByPrice);
 
+	if (!bDisableItemLimitCheck && WeapDefs.Length > ITEMS_LIMIT)
+	{
+		`Log_Warn("The total number of items has reached the limit (" $ ITEMS_LIMIT $ ")," @ (WeapDefs.Length - ITEMS_LIMIT) @ "items will not be added.");
+		`Log_Warn("Excluded items:");
+		for (Index = ITEMS_LIMIT; Index < WeapDefs.Length; ++Index)
+		{
+			`Log_Warn("[" $ Index + 1 $ "]" @ String(WeapDefs[Index]));
+		}
+		WeapDefs.Length = ITEMS_LIMIT;
+	}
+
+	OverwriteTraderItems(KFGRI, WeapDefs, LogLevel);
+}
+
+public static simulated function OverwriteTraderItems(
+	KFGameReplicationInfo KFGRI,
+	const out Array<class<KFWeaponDefinition> > WeapDefs,
+	E_LogLevel LogLevel)
+{
+	local KFGFxObject_TraderItems TraderItems;
+	local STraderItem Item;
+	local class<KFWeaponDefinition> WeapDef;
+	local int MaxItemID;
+
+	`Log_TraceStatic();
+
+	TraderItems = GetTraderItems(KFGRI, LogLevel);
+
 	TraderItems.SaleItems.Length = 0;
 	MaxItemID = 0;
+
+	`Log_Debug("Trader Items:");
 	foreach WeapDefs(WeapDef)
 	{
 		Item.WeaponDef = WeapDef;
-		Item.ItemID = ++MaxItemID;
+		Item.ItemID = MaxItemID++;
 		TraderItems.SaleItems.AddItem(Item);
+		`Log_Debug("[" $ MaxItemID $ "]" @ String(WeapDef));
 	}
 
 	TraderItems.SetItemsInfo(TraderItems.SaleItems);
@@ -142,7 +177,7 @@ public static simulated function ModifyTrader(
 	KFGRI.TraderItems = TraderItems;
 }
 
-private static function bool WeaponClassIsUnique(String WeaponClassPath, Array<class<KFWeaponDefinition> > WeapDefs, E_LogLevel LogLevel)
+private static function bool WeaponClassIsUnique(String WeaponClassPath, const out Array<class<KFWeaponDefinition> > WeapDefs, E_LogLevel LogLevel)
 {
 	local class<KFWeaponDefinition> WeapDef;
 

CTI/Classes/Unlocker.uc

@@ -122,6 +122,11 @@ private static function bool ReplaceWeapons(
 			PartialUnlock = true;
 			`Log_Warn("Can't unlock item:" @ WeapDefDLC @ "SharedUnlockId:" @ WeapDefDLC.default.SharedUnlockId);
 		}
+
+		if (RemoveItems.Find(WeapDefDLC) == INDEX_NONE)
+		{
+			RemoveItems.AddItem(WeapDefDLC);
+		}
 	}
 
 	if (PartialUnlock)
@@ -192,6 +197,7 @@ defaultproperties
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_Pistol_G18C')
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_Rifle_FrostShotgunAxe')
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_Scythe')
+	WeapDefDLCReplacements.Add(class'CTI_WeapDef_Shotgun_S12')
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_ShrinkRayGun')
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_ThermiteBore')
 	WeapDefDLCReplacements.Add(class'CTI_WeapDef_ZedMKIII')

PublicationContent/description.txt

@@ -73,7 +73,7 @@ example: [b]Item=WeaponPack.KFWeapDef_XM25[/b] will add [url=https://steamcommun
 [/list]
 
 ❗️ Note that if you need an empty list anywhere (for example, you don't want to delete some of the traders's weapons), leave at least one line there:
-[b]Item=""[/b]
+[b]Item=[/b]
 This is necessary to explicitly initialize the list (because of the bug I wrote about above) to avoid initialization with random values.
 
 [h1]Notes[/h1]

README.md

@@ -3,24 +3,24 @@
 [![Steam Workshop](https://img.shields.io/static/v1?message=workshop&logo=steam&labelColor=gray&color=blue&logoColor=white&label=steam%20)](https://steamcommunity.com/sharedfiles/filedetails/?id=2830826239)
 [![Steam Downloads](https://img.shields.io/steam/downloads/2830826239)](https://steamcommunity.com/sharedfiles/filedetails/?id=2830826239)
 [![Steam Favorites](https://img.shields.io/steam/favorites/2830826239)](https://steamcommunity.com/sharedfiles/filedetails/?id=2830826239)
-[![Steam Update Date](https://img.shields.io/steam/update-date/2830826239)](https://steamcommunity.com/sharedfiles/filedetails/?id=2830826239)
+[![MegaLinter](https://github.com/GenZmeY/KF2-CustomTraderInventory/actions/workflows/mega-linter.yml/badge.svg?branch=master)](https://github.com/GenZmeY/KF2-CustomTraderInventory/actions/workflows/mega-linter.yml)
 [![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/GenZmeY/KF2-CustomTraderInventory)](https://github.com/GenZmeY/KF2-CustomTraderInventory/tags)
 [![GitHub](https://img.shields.io/github/license/GenZmeY/KF2-CustomTraderInventory)](LICENSE)
 
-# Description
+## Description
 Add/Remove Items in the Trader's Inventory  
 
-# Features
+## Features
 - remove/add items to trader;
 - can preload weapon models (no lags when buying weapons);
 - unlock DLC weapons;
 - correct items sorting (by price);
 - don't have to worry about adding new guns after each Tripware update.
 
-# Usage & Setup
+## Usage & Setup
 [See steam workshop page](https://steamcommunity.com/sharedfiles/filedetails/?id=2830826239)
 
-# Build
+## Build
 **Note:** If you want to build/test/brew/publish a mutator without git-bash and/or scripts, follow [these instructions](https://tripwireinteractive.atlassian.net/wiki/spaces/KF2SW/pages/26247172/KF2+Code+Modding+How-to) instead of what is described here.
 1. Install [Killing Floor 2](https://store.steampowered.com/app/232090/Killing_Floor_2/), Killing Floor 2 - SDK and [git for windows](https://git-scm.com/download/win);
 2. open git-bash and go to any folder where you want to store sources:  
@@ -34,16 +34,9 @@ Add/Remove Items in the Trader's Inventory
 5. The compiled files will be here:  
 `C:\Users\<USERNAME>\Documents\My Games\KillingFloor2\KFGame\Unpublished\BrewedPC\Script\`
 
-# Testing
-Open git-bash in the source folder and run command:  
-`./tools/builder -t`  
-(or `./tools/builder -ct` if you haven't compiled the mutator yet)  
-
-A local single-user test will be launched with parameters from `builder.cfg` (edit this file if you want to test mutator with different parameters).
-
-# Bug reports
+## Bug reports
 If you find a bug, go to the [issue page](https://github.com/GenZmeY/KF2-CustomTraderInventory/issues) and check if there is a description of your bug. If not, create a new issue.  
 Describe what the bug looks like and how reproduce it.  
 
-# License
-[GNU GPLv3](LICENSE)  
+## License
+[![license](https://www.gnu.org/graphics/gplv3-with-text-136x68.png)](LICENSE)